Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics | Report expected UTDs as HistoricalMessage error #7775

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

BillCarsonFr
Copy link
Member

Part of #7767

Depends on SDK Change: matrix-org/matrix-ios-sdk#1848

Adds eventLocalAgeMillis and trustOwnIdentityAtTimeOfFailure properties for posthog reporting. Also use a new error name when a decryption is expected to fail: HistoricalMessage (device historical and session not verified so can't access backup)

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@BillCarsonFr BillCarsonFr requested a review from stefanceriu April 4, 2024 11:04
@BillCarsonFr BillCarsonFr self-assigned this Apr 4, 2024
Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@BillCarsonFr BillCarsonFr marked this pull request as ready for review April 11, 2024 07:39
@BillCarsonFr BillCarsonFr merged commit 24fb540 into develop Apr 11, 2024
7 checks passed
@BillCarsonFr BillCarsonFr deleted the valere/analytics_expected_utds branch April 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants