-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker nginx config to not force ipv6 #28729
Conversation
ipv6 support is automatically added via nginx docker's 10-listen-on-ipv6-by-default.sh. This patch allows element-web to run on system with or without ipv6 enabled.
x seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Vote against from me :-). Sorry, my nginx does not come throough docker and I don't believe disabling IPv6 by default makes sense nowadays. Add a comment to tell people to comment this out if they don't use IPv6, but no one should be just using this config without going through it and adapting it as they need fit anyway. Don't just disable IPv6. |
The config isn't intended as an example, but the config we use for our Docker image only. @yxie2023 could you move the |
done @t3chguy. let me know if there's anything else. thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, thanks
@yxie2023 you would need to sign the CLA if you want your contribution to be merged. Also looks like Sonarcloud won't scan your own |
I signed the CLA. Resubmitting from "contrib" branch: #28771 |
Pull request was closed
ipv6 support is automatically added via nginx docker's 10-listen-on-ipv6-by-default.sh.
This patch allows element-web to run on system with or without ipv6 enabled.
Checklist
public
/exported
symbols have accurate TSDoc documentation.