Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AccountPasswordStore and related flows #28750

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 17, 2024

As they are no longer needed since MSC3967

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
As they are no longer needed since MSC3967

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Dec 17, 2024
@t3chguy t3chguy self-assigned this Dec 17, 2024
Iterate

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Michael Telatynski <[email protected]>
Iterate

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Michael Telatynski <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Michael Telatynski <[email protected]>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, although I'm afraid I've just merged my PR which changed a bunch of this stuff.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…to t3chguy/msc3967-cleanup

# Conflicts:
#	src/CreateCrossSigning.ts
#	src/stores/InitialCryptoSetupStore.ts
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible, I guess

Comment on lines 18 to 19
* Ensures that cross signing keys are created and uploaded for the user.
* The homeserver may require user-interactive auth to upload the keys, in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this comment is outdated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the handling for that is still there, the server may require it, if it is old enough to not support that MSC/spec version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh a later part of the comment is outdated though

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's what I meant. GH wouldn't let me comment on it.

src/CreateCrossSigning.ts Show resolved Hide resolved
@t3chguy t3chguy added this pull request to the merge queue Dec 19, 2024
@t3chguy t3chguy removed this pull request from the merge queue due to a manual request Dec 19, 2024
t3chguy and others added 3 commits December 19, 2024 11:42

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Richard van der Hoff <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Michael Telatynski <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…chguy/msc3967-cleanup
@t3chguy t3chguy enabled auto-merge December 19, 2024 11:46
@t3chguy t3chguy added this pull request to the merge queue Dec 19, 2024
Merged via the queue into develop with commit cd7cf86 Dec 19, 2024
33 checks passed
@t3chguy t3chguy deleted the t3chguy/msc3967-cleanup branch December 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants