-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AccountPasswordStore and related flows #28750
Conversation
As they are no longer needed since MSC3967 Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, although I'm afraid I've just merged my PR which changed a bunch of this stuff.
…to t3chguy/msc3967-cleanup # Conflicts: # src/CreateCrossSigning.ts # src/stores/InitialCryptoSetupStore.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems plausible, I guess
* Ensures that cross signing keys are created and uploaded for the user. | ||
* The homeserver may require user-interactive auth to upload the keys, in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this comment is outdated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, the handling for that is still there, the server may require it, if it is old enough to not support that MSC/spec version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh a later part of the comment is outdated though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's what I meant. GH wouldn't let me comment on it.
Co-authored-by: Richard van der Hoff <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
As they are no longer needed since MSC3967