-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move room header info button to right-most position #28754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
americanrefugee
suggested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost :)
The Info icon should go before the face pile, not after it. Like this:
https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2/Room-Header-%26-Details-(2024)?node-id=2-56467&t=OXJ54i1YWLoTMobH-4
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
americanrefugee
approved these changes
Dec 17, 2024
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Dec 18, 2024
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 15, 2025
https://build.opensuse.org/request/show/1238072 by user dheidler + anag+factory - Version 1.11.90 ## ✨ Features * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh. * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh. * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy. * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy. * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy. * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy. * Enable key backup by defa
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 15, 2025
https://build.opensuse.org/request/show/1238071 by user dheidler + anag+factory - Version 1.11.90 ## ✨ Features * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh. * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh. * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy. * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy. * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy. * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy. * Enable key backup by defa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes superfluous Flex div which decreased the icon spacing lower than specified in Figma