Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move room header info button to right-most position #28754

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 17, 2024

Removes superfluous Flex div which decreased the icon spacing lower than specified in Figma

Signed-off-by: Michael Telatynski <[email protected]>
Copy link

@americanrefugee americanrefugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost :)

The Info icon should go before the face pile, not after it. Like this:
https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2/Room-Header-%26-Details-(2024)?node-id=2-56467&t=OXJ54i1YWLoTMobH-4

Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review December 17, 2024 16:33
@t3chguy t3chguy requested a review from a team as a code owner December 17, 2024 16:33
@t3chguy t3chguy requested review from dbkr and florianduros December 17, 2024 16:33
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added this pull request to the merge queue Dec 18, 2024
Merged via the queue into develop with commit 95c879c Dec 18, 2024
33 checks passed
@t3chguy t3chguy deleted the t3chguy/room-header-order branch December 18, 2024 10:13
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 15, 2025
https://build.opensuse.org/request/show/1238072
by user dheidler + anag+factory
- Version 1.11.90
  ## ✨ Features
  * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh.
  * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh.
  * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy.
  * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy.
  * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy.
  * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy.
  * Enable key backup by defa
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 15, 2025
https://build.opensuse.org/request/show/1238071
by user dheidler + anag+factory
- Version 1.11.90
  ## ✨ Features
  * Docker: run as non-root (element-hq/element-web#28849). Contributed by @richvdh.
  * Docker: allow configuration of HTTP listen port via env var (element-hq/element-web#28840). Contributed by @richvdh.
  * Update matrix-wysiwyg to consume WASM asset (element-hq/element-web#28838). Contributed by @t3chguy.
  * OIDC settings tweaks (element-hq/element-web#28787). Contributed by @t3chguy.
  * Delabs native OIDC support (element-hq/element-web#28615). Contributed by @t3chguy.
  * Move room header info button to right-most position (element-hq/element-web#28754). Contributed by @t3chguy.
  * Enable key backup by defa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants