Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update matrix-authentication-service in Playwright tests #28876

Merged
merged 5 commits into from
Jan 6, 2025
Merged

Update matrix-authentication-service in Playwright tests #28876

merged 5 commits into from
Jan 6, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jan 6, 2025 •
edited
Loading

Requires tweaking some of the tests given the MAS UI changed
Means also we can simplify the Synapse config DRASTICALLY

Subset of #28860

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jan 6, 2025
@t3chguy t3chguy self-assigned this Jan 6, 2025
@t3chguy
delint
1cd1dcd 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Iterate
84126e8 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy mentioned this pull request Jan 6, 2025
Merged
@t3chguy
Actually do the update
d506dec 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix mas run
4cacb83 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy marked this pull request as ready for review January 6, 2025 16:24
@t3chguy t3chguy requested a review from a team as a code owner January 6, 2025 16:24
@t3chguy t3chguy requested review from dbkr and MidhunSureshR January 6, 2025 16:24
dbkr
dbkr approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that certainly does remove a lot of config.

@t3chguy t3chguy added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit b16088d Jan 6, 2025
39 checks passed
@t3chguy t3chguy deleted the t3chguy/playwright-update-mas branch January 6, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @dbkr