Style room header icons and facepile for toggled state #28968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we track changes to the right panel phases
We do this so that we can get by using a single event listener i.e we only need to call `useCurrentPhase` in the provider as opposed to calling it in each header icon.
and adds a class name when the corresponding panel is open
MidhunSureshR
force-pushed
the
midhun/room-header-active-icons
branch
from
eeb1852 to
d52937d
Compare
t3chguy
reviewed
Jan 27, 2025
| @@ -0,0 +1,30 @@ | |||
| /* | |||
| Copyright 2024 New Vector Ltd. | |||
| @@ -0,0 +1,23 @@ | |||
| /* | |||
| Copyright 2024 New Vector Ltd. | |||
| @@ -0,0 +1,34 @@ | |||
| /* | |||
| Copyright 2024 New Vector Ltd. | |||
| @@ -0,0 +1,45 @@ | |||
| /* | |||
| Copyright 2024 New Vector Ltd. | |||
| import { useToggled } from "./useToggled"; | ||
|
|
||
| type Props = { | ||
| Icon: React.ComponentType<any>; |
There was a problem hiding this comment.
using any here is weak, that doesn't even guarantee the component accepts className as it is used
t3chguy
approved these changes
Jan 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/element-hq/wat-internal/issues/240 and https://github.com/element-hq/wat-internal/issues/242
According to the figma designs, the toggled on state of the room header buttons should look like:
and the face pile should look like:
