Allow reaction to non sent Event (local echo for reaction) #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
bmarty
force-pushed
the
feature/bma/reactionLocalEcho
branch
from
75e7668 to
ac2c1f9
Compare
bmarty
force-pushed
the
feature/bma/reactionLocalEcho
branch
from
ac2c1f9 to
ab184cb
Compare
|
Also the SDK will manage local echo for reactions.
bmarty
changed the title
bmarty
commented
Aug 28, 2024
| @@ -155,7 +156,7 @@ interface MatrixRoom : Closeable { | |||
|
|
|||
| suspend fun sendFile(file: File, fileInfo: FileInfo, progressCallback: ProgressCallback?): Result<MediaUploadHandler> | |||
|
|
|||
| suspend fun toggleReaction(emoji: String, eventId: EventId): Result<Unit> | |||
| suspend fun toggleReaction(emoji: String, uniqueId: UniqueId): Result<Unit> | |||
There was a problem hiding this comment.
UniqueId is useful here (for instance) to avoid having 2 Strings as parameter.
|
The branch has been merged to another one and is now in this PR: #3384. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Add support for local echo reaction. This is mainly allowing reaction to be added on non-sent event.
First commit introduce
UniqueIdvalue class, I recommend to review commit per commit.Need matrix-org/matrix-rust-sdk#3749
Motivation and context
Improve reaction feature.
Screenshots / GIFs
Tests
There is a limitation described here which will may be fixed SDK side (the PR is not merged yet).
Tested devices
Checklist