Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: Use OnlySigned isolation flag to setup decryption trust req. #3569

Merged
merged 2 commits into from
Oct 4, 2024
Merged

crypto: Use OnlySigned isolation flag to setup decryption trust req. #3569

merged 2 commits into from
Oct 4, 2024

Conversation

BillCarsonFr
Copy link
Member

Depends on matrix-org/matrix-rust-sdk#4046

part of https://github.com/element-hq/crypto-internal/issues/353
For now the new decryption errors will show as regular ones (waiting for this message), a following PR will fix that once the sdk has support for different UTD errors

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from de61d5d to 81fe094 Compare October 1, 2024 12:28
@BillCarsonFr BillCarsonFr added the PR-Misc For other changes label Oct 3, 2024
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from 5a59fba to 5bfbeb0 Compare October 3, 2024 07:22
@BillCarsonFr BillCarsonFr mentioned this pull request Oct 4, 2024
Open
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from 5bfbeb0 to 5fd54c1 Compare October 4, 2024 07:23
@BillCarsonFr BillCarsonFr changed the base branch from develop to feature/valere/bump_rust_sdk_0.2.51 October 4, 2024 11:02
@BillCarsonFr BillCarsonFr changed the base branch from feature/valere/bump_rust_sdk_0.2.51 to develop October 4, 2024 11:02
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from 5fd54c1 to 64f7aa6 Compare October 4, 2024 12:46
@BillCarsonFr BillCarsonFr marked this pull request as ready for review October 4, 2024 12:46
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner October 4, 2024 12:46
@BillCarsonFr BillCarsonFr requested review from bmarty and removed request for a team October 4, 2024 12:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iPUY9U

@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (98d9abe) to head (3259539).
Report is 21 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3569   +/-   ##
========================================
  Coverage    82.68%   82.68%           
========================================
  Files         1731     1731           
  Lines        41014    41014           
  Branches      4973     4973           
========================================
  Hits         33912    33912           
  Misses        5342     5342           
  Partials      1760     1760

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty
bmarty approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from 64f7aa6 to 5aa504f Compare October 4, 2024 14:35
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/only_signed_decryption_mode branch from 5aa504f to 3259539 Compare October 4, 2024 15:07
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BillCarsonFr BillCarsonFr added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Oct 4, 2024
@BillCarsonFr BillCarsonFr merged commit 4319a42 into develop Oct 4, 2024
30 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/only_signed_decryption_mode branch October 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillCarsonFr @bmarty