Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kotlin to v2.0 #3594

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Upgrade Kotlin to v2.0 #3594

wants to merge 3 commits into from

Conversation

jmartinesp
Copy link
Member

Content

  • Upgrade Kotlin to v2.0.20.
  • Also upgrade KotlinPoet associated dependency.
  • Change deprecated gradle configs.
  • Use the setupAnvil() method in some gradle modules that added the anvil plugin manually instead.
  • Fix deprecations and lint issues.
  • Add LambdaSuspendRecorder since Kotlin 2.0+ differentiates between a () -> Unit lambda and a suspend () -> Unit so we need a special one for suspend lambdas.

Motivation and context

Keeping the dev env up to date.

Tests

Let's keep an eye on the CI.

The app runs fine when built locally.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@jmartinesp jmartinesp added the PR-Dependencies Pull requests that update a dependency file label Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (f8fa218) to head (54bb9c0).

Files with missing lines Patch % Lines
...screens/createaccount/WebViewMessageInterceptor.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3594      +/-   ##
===========================================
+ Coverage    81.71%   82.19%   +0.48%     
===========================================
  Files         1751     1745       -6     
  Lines        41936    41777     -159     
  Branches      5071     5086      +15     
===========================================
+ Hits         34269    34340      +71     
+ Misses        5893     5634     -259     
- Partials      1774     1803      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp
Copy link
Member Author

Depends on element-hq/matrix-rich-text-editor#24 to build without warnings.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/E4y5RZ

Copy link

sonarcloud bot commented Oct 4, 2024

@jmartinesp jmartinesp marked this pull request as ready for review October 4, 2024 19:08
@jmartinesp jmartinesp requested a review from a team as a code owner October 4, 2024 19:08
@jmartinesp jmartinesp requested review from bmarty and removed request for a team October 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant