Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polls analytics #1691

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add polls analytics #1691

merged 2 commits into from
Sep 13, 2023

Conversation

alfogrillo
Copy link
Contributor

Implements the poll related analytics added here.
It also refactors the location analytics since the api has changed.

@alfogrillo alfogrillo self-assigned this Sep 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo mentioned this pull request Sep 12, 2023
Closed
@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f86a7f1

@alfogrillo alfogrillo marked this pull request as ready for review September 12, 2023 14:53
@alfogrillo alfogrillo requested a review from a team as a code owner September 12, 2023 14:53
@alfogrillo alfogrillo requested review from stefanceriu and removed request for a team September 12, 2023 14:53
stefanceriu
stefanceriu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@alfogrillo alfogrillo merged commit f3618cd into develop Sep 13, 2023
5 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/polls-analytics branch September 13, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees

@alfogrillo alfogrillo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alfogrillo @stefanceriu