Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically sign out when toggling the Simplified Sliding Sync feature flag. #3071

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

pixlwave
Copy link
Member

Otherwise the Sliding Sync proxy will be taking your keys 🥲

Requires matrix-org/matrix-rust-sdk#3743 for login to work.

@pixlwave pixlwave added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jul 19, 2024
@pixlwave pixlwave requested a review from a team as a code owner July 19, 2024 15:57
@pixlwave pixlwave requested review from Velin92 and removed request for a team July 19, 2024 15:57
Copy link

github-actions bot commented Jul 19, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b4cedb8

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 77.97%. Comparing base (9879552) to head (b4cedb8).
Report is 1 commits behind head on develop.

Files Patch % Lines
...ptionsScreen/DeveloperOptionsScreenViewModel.swift 0.00% 10 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 6 Missing ⚠️
...ces/FlowCoordinators/SettingsFlowCoordinator.swift 0.00% 2 Missing ⚠️
...ionsScreen/DeveloperOptionsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 1 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 1 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 1 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 1 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3071      +/-   ##
===========================================
- Coverage    78.00%   77.97%   -0.04%     
===========================================
  Files          703      703              
  Lines        54346    54362      +16     
===========================================
- Hits         42395    42391       -4     
- Misses       11951    11971      +20     
Flag Coverage Δ
unittests 68.57% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 23, 2024

@pixlwave pixlwave merged commit bf22250 into develop Jul 23, 2024
6 checks passed
@pixlwave pixlwave deleted the doug/sss-logout branch July 23, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants