-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned items timeline implementation for the banner #3099
Conversation
Generated by 🚫 Danger Swift against 431a90c |
Quality Gate passedIssues Measures |
ElementX/Sources/Services/Room/RoomSummary/RoomMessageEventStringBuilder.swift
Show resolved
Hide resolved
3a87919
to
10702ce
Compare
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3099 +/- ##
===========================================
- Coverage 77.80% 77.72% -0.09%
===========================================
Files 713 713
Lines 54994 55078 +84
===========================================
+ Hits 42786 42807 +21
- Misses 12208 12271 +63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, 🚀 it! 👏
5c34f03
to
431a90c
Compare
fixes #3072
Requires matrix-org/matrix-rust-sdk#3773 to be merged
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-05.at.11.30.17.mp4