Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned items timeline implementation for the banner #3099

Merged
merged 8 commits into from
Aug 5, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 29, 2024

fixes #3072

Requires matrix-org/matrix-rust-sdk#3773 to be merged

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-05.at.11.30.17.mp4

Copy link

github-actions bot commented Jul 29, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 431a90c

Copy link

sonarcloud bot commented Jul 29, 2024

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Jul 31, 2024
@Velin92 Velin92 force-pushed the mauroromito/timeline_wip branch from 3a87919 to 10702ce Compare August 5, 2024 09:28
@Velin92 Velin92 marked this pull request as ready for review August 5, 2024 09:28
@Velin92 Velin92 requested a review from a team as a code owner August 5, 2024 09:28
@Velin92 Velin92 requested review from stefanceriu and removed request for a team August 5, 2024 09:28
Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 77 lines in your changes missing coverage. Please review.

Project coverage is 77.72%. Comparing base (cdaa88e) to head (10702ce).

Files Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 22.85% 27 Missing ⚠️
...om/RoomSummary/RoomMessageEventStringBuilder.swift 0.00% 27 Missing ⚠️
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 66.66% 10 Missing ⚠️
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 66.66% 4 Missing ⚠️
...tX/Sources/Other/Extensions/AttributedString.swift 0.00% 3 Missing ⚠️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 50.00% 2 Missing ⚠️
...ne/TimelineController/RoomTimelineController.swift 0.00% 2 Missing ⚠️
...lineController/RoomTimelineControllerFactory.swift 0.00% 1 Missing ⚠️
NSE/Sources/NotificationContentBuilder.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3099      +/-   ##
===========================================
- Coverage    77.80%   77.72%   -0.09%     
===========================================
  Files          713      713              
  Lines        54994    55078      +84     
===========================================
+ Hits         42786    42807      +21     
- Misses       12208    12271      +63     
Flag Coverage Δ
unittests 68.22% <46.15%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, 🚀 it! 👏

@Velin92 Velin92 force-pushed the mauroromito/timeline_wip branch from 5c34f03 to 431a90c Compare August 5, 2024 12:08
@Velin92 Velin92 merged commit ff2c42d into develop Aug 5, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/timeline_wip branch August 5, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants