-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encryption Flow Coordinators. #3471
Conversation
Generated by 🚫 Danger Swift against 9092350 |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3471 +/- ##
===========================================
- Coverage 77.90% 77.72% -0.18%
===========================================
Files 744 745 +1
Lines 61427 61564 +137
===========================================
- Hits 47853 47851 -2
- Misses 13574 13713 +139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is the next part needed for #3399:
The whole
SecureBackup…
/EncryptionReset…
flow was intertwined, using the screen coordinators to perform navigation, manipulating the stack, and including some duplication between the Settings flow and the Onboarding flow. This PR makes the following changes:EncryptionSettingsFlowCoordinator
and aEncryptionResetFlowCoordinator
which take all navigation responsibility away from the screens. They're based on state machines which now I'm done I realise is a bit overkill given by the end of the refactor they're both very simple, however now that those are in place it seems better to leave them for the future than remove them (e.g.EncryptionSettingsFlowCoordinator
is going to get another section that I think is going to involve a bit more complex set up).EncryptionSettingsFlowCoordinator
as it turns out the view action for this was removed in Tweak the UI in the EncryptionReset, IdentityConfirmation and SecureBackupRecovery screens. #3391, but the view model upwards was left in place 🤦♂️Sorry this grew so large, I can now see how it could have been split into 2 smaller PRs but that wasn't apparent until most of the refactor was done. It is split into reviewable commits though.