Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations update #3477

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Translations update #3477

merged 1 commit into from
Nov 6, 2024
+707 −554

Conversation

RiotRobot
Copy link
Collaborator

  • Translations update

@RiotRobot RiotRobot requested a review from a team as a code owner November 4, 2024 00:01
@RiotRobot RiotRobot added the pr-i18n for translations label Nov 4, 2024
@RiotRobot RiotRobot requested review from pixlwave and removed request for a team November 4, 2024 00:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against be8109d

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
848 1 847 0
View the full list of 1 ❄️ flaky tests 
RoomScreenViewModelTests testPinnedEventsBanner()

Flake rate in main: 25.00% (Passed 153 times, Failed 51 times)

Stack Traces | 13.7s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Sources/Extensions/XCTestCase.swift:43)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu merged commit 8de44b9 into develop Nov 6, 2024
7 checks passed
@stefanceriu stefanceriu deleted the translations/update branch November 6, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

@pixlwave pixlwave Awaiting requested review from pixlwave pixlwave is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
pr-i18n for translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RiotRobot @Velin92 @stefanceriu