Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using roomPreview API for invited rooms #3530

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 18, 2024

In this way we can get rid of the deprecated invitedRoom API

However we need also the heroes and the displayName for this PR to be fully ready

@Velin92 Velin92 requested a review from a team as a code owner November 18, 2024 17:05
@Velin92 Velin92 requested review from pixlwave and removed request for a team November 18, 2024 17:05
Copy link

github-actions bot commented Nov 18, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 22dd6d2

@Velin92 Velin92 added the pr-change for updates to an existing feature label Nov 18, 2024
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

ElementX/Sources/Services/Room/RoomInfoProxy.swift Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 18, 2024

Copy link

codecov bot commented Nov 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
861 1 860 0
View the full list of 1 ❄️ flaky tests
PreviewTests test_joinRoomScreen()

Flake rate in main: 12.59% (Passed 118 times, Failed 17 times)

Stack Traces | 3.79s run time
failed - Snapshot "Invite" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invite.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invite.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.97735596 is less than required 1.0
The lowest perceptual color precision 0.23312497 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@Velin92 Velin92 marked this pull request as draft November 18, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants