Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report extra UTD error properties to PostHog #3612

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

BillCarsonFr
Copy link
Member

Add a few new properties to the UTD reports we send to Posthog.

Part of element-hq/element-meta#2582

Requires matrix-org/matrix-rust-sdk#4404.

EXA equivalent element-hq/element-x-android#4020

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner December 12, 2024 17:52
@BillCarsonFr BillCarsonFr requested review from stefanceriu and removed request for a team December 12, 2024 17:52
Copy link

github-actions bot commented Dec 12, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against 4c89ecc

@BillCarsonFr BillCarsonFr added the pr-misc for other changes label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (92ca7b5) to head (4c89ecc).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 0.00% 18 Missing ⚠️
.../Sources/Services/Analytics/AnalyticsService.swift 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3612      +/-   ##
===========================================
- Coverage    78.38%   78.32%   -0.06%     
===========================================
  Files          779      779              
  Lines        65549    65550       +1     
===========================================
- Hits         51382    51345      -37     
- Misses       14167    14205      +38     
Flag Coverage Δ
unittests 69.96% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you for taking care of it! 🙌

@stefanceriu stefanceriu force-pushed the valere/extra_posthog_utd_properties branch from 32250e2 to 4c89ecc Compare December 13, 2024 10:37
@stefanceriu stefanceriu enabled auto-merge (rebase) December 13, 2024 10:37
Copy link

sonarcloud bot commented Dec 13, 2024

@stefanceriu stefanceriu merged commit 56ffe40 into develop Dec 13, 2024
8 checks passed
@stefanceriu stefanceriu deleted the valere/extra_posthog_utd_properties branch December 13, 2024 10:56
@pixlwave pixlwave changed the title feat(posthog): wire support for extra utd error properties Report extra UTD error properties to PostHog Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants