Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new UtdCause for historical messages #3625

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

BillCarsonFr
Copy link
Member

Depends on matrix-org/matrix-rust-sdk#4384

Adds support for new Historical expected UTDs (posthog and display of errors in timeline)

part of element-hq/element-meta#2638
EXA equivalent: element-hq/element-x-android#4044

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

Copy link

github-actions bot commented Dec 16, 2024

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a12292f

Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fits with my understanding, thanks!

@Velin92
Copy link
Member

Velin92 commented Dec 16, 2024

@BillCarsonFr recently I have updated the SDK, so maybe is worth rebasing this PR.
I have seen two new historicalMessage cases have been added.
For now i managing them with what we had got so far, but maybe your PR can address that change better than mine.

@stefanceriu stefanceriu force-pushed the valere/extended_historical_utd_cause branch from 66613d2 to a12292f Compare December 17, 2024 07:41
@stefanceriu stefanceriu added the pr-api for an api break label Dec 17, 2024
@stefanceriu
Copy link
Member

I took care of it, let's see what happens

Copy link

sonarcloud bot commented Dec 17, 2024

Copy link

codecov bot commented Dec 17, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
903 2 901 0
View the top 1 failed tests by shortest run time
PreviewTests test_identityConfirmationScreen()
Stack Traces | 3.53s run time
failed - Snapshot does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"
@+
"file:.../tmp/PreviewTests/test_identityConfirmationScreen-iPhone-16-en-GB.1.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.89941406 is less than required 1.0
The lowest perceptual color precision 0.39937502 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)
View the full list of 1 ❄️ flaky tests
PreviewTests test_timelineMediaPreviewDetailsView()

Flake rate in main: 23.40% (Passed 72 times, Failed 22 times)

Stack Traces | 1.15s run time
failed - Snapshot "Image" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"
@+
"file:.../tmp/PreviewTests/test_timelineMediaPreviewDetailsView-iPhone-16-pseudo.Image.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9949837 is less than required 1.0
The lowest perceptual color precision 0.29250002 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@stefanceriu stefanceriu marked this pull request as ready for review December 17, 2024 08:15
@stefanceriu stefanceriu merged commit 52463cd into develop Dec 17, 2024
10 checks passed
@stefanceriu stefanceriu deleted the valere/extended_historical_utd_cause branch December 17, 2024 08:15
@pixlwave pixlwave changed the title feat(crypto): Support for new UtdCause for historical messages Support for new UtdCause for historical messages Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-api for an api break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants