This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Add labs option to exclude unverified devices #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/ignore_insecure_devices
branch
2 times, most recently
from
ebcfbdd
to
a3d4de0
Compare
richvdh
force-pushed
the
rav/ignore_insecure_devices
branch
from
a3d4de0
to
a164d95
Compare
Add a labs option which will, when set, switch into the "invisible crypto" mode of refusing to send keys to, or decrypt messages from, devices that have not been signed by their owner.
richvdh
force-pushed
the
rav/ignore_insecure_devices
branch
from
a164d95
to
bff059a
Compare
4 tasks
florianduros
approved these changes
Sep 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
richvdh
added a commit
that referenced
this pull request
Sep 30, 2024
…`false` #92 changed the default mode for encryption to throw an error when sending a message and the room contains either: - a verified user with an unverified device - a verifeid user who has changed their identity. We're not really ready for this (we lack the UI to deal with it), so roll that back.
richvdh
added a commit
that referenced
this pull request
Sep 30, 2024
…`false` #92 changed the default mode for encryption to throw an error when sending a message and the room contains either: - a verified user with an unverified device - a verifeid user who has changed their identity. We're not really ready for this (we lack the UI to deal with it), so roll that back.
richvdh
added a commit
that referenced
this pull request
Sep 30, 2024
…`false` #92 changed the default mode for encryption to throw an error when sending a message and the room contains either: - a verified user with an unverified device - a verifeid user who has changed their identity. We're not really ready for this (we lack the UI to deal with it), so roll that back.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…`false` (#104) #92 changed the default mode for encryption to throw an error when sending a message and the room contains either: - a verified user with an unverified device - a verifeid user who has changed their identity. We're not really ready for this (we lack the UI to deal with it), so roll that back.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 9, 2024
https://build.opensuse.org/request/show/1206522 by user dheidler + anag+factory - Version 1.11.80 ## ✨ Features * Add doc for 'force\_verification config option (element-hq/element-web#28035). Contributed by @dbkr. * Roll back change to device isolation mode (element-hq/matrix-react-sdk#104). Contributed by @richvdh. * Remove right panel toggling behaviour on room header buttons (element-hq/matrix-react-sdk#100). Contributed by @t3chguy. * Improve error display for messages sent from insecure devices (element-hq/matrix-react-sdk#93). Contributed by @richvdh. * Add labs option to exclude unverified devices (element-hq/matrix-react-sdk#92). Contributed by @richvdh. * Improve contrast for timestamps, date separators \& spotlight trigger (ht
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/element-hq/crypto-internal/issues/362.
Add a labs option which will, when set, switch into the "invisible crypto" mode of refusing to send keys to, or decrypt messages from, devices that have not been signed by their owner.
Builds on top of the "Device Isolation Mode" functionality added to the js-sdk in matrix-org/matrix-js-sdk#4429.
The wording has been discussed at element-hq/element-meta#2536 (comment).
It looks like this:
When configured via
config.json, the setting is greyed out, like this: