Support MSC4140: Delayed events (Futures) #17326
Commits on Aug 6, 2024
Commits on Aug 7, 2024
-
-
-
-
-
-
-
-
Check startup delayed state events for same state
If on startup there are multiple delayed state events to be sent, do not send multiple events that target the same state key for a room.
-
-
-
-
-
Increase expected db_txn_counts
Include counts for the delayed event handler's state event callback
-
Commits on Aug 8, 2024
Commits on Aug 15, 2024
-
-
-
Use "Params" instead of "Args" in docstrings
to follow Google's Python style guide https://google.github.io/styleguide/pyguide.html#doc-function-args
-
-
-
-
-
Remove TODO to verify delayed event contents
because they are already verified when the event is scheduled
-
Don't bother using a CRC for delay_ids
as all they need to be is a random opaque string
-
Assert non-negative delay; allow missing delay ID
A delayed event missing from the DB on timeout isn't destructive, so don't worry about asserting for its presence. Do post a debug message explaining its absence, though
-
-
-
Use built-in method to check for RETURNING support
and remove some now-unneeded imports
-
Co-authored-by: Andrew Morgan <[email protected]>
Commits on Aug 19, 2024
-
Remove support for delayed event parents
as they are not part of MSC4140 anymore (and if reinstated, will likely require their own MSC)
Commits on Aug 20, 2024
-
-
-
Don't bother handling DB key collisions
because generated delay IDs should have enough entropy for collisions to be extremely rare
-
-
-
-
-
-
Remove delayed event from DB on cancel
This was always supposed to be done, but was lost a few commits ago
Commits on Aug 21, 2024
-
Make user_localpart first column of DB key
to allow for faster queries on user_localpart alone
-
Don't handle missing delays in DB lookup
because delay is now a mandatory field of all delayed events
-
-
Remove redundant delay value check
Should have been done in 47b6e69
Commits on Aug 28, 2024
-
- Move from "experimental" config section to "server" - Allow to be set to None to disable delayed event sending - Parse as a duration string, not just an integer of milliseconds - Set default value to None, i.e. disable delayed events by default
-
Refactor delayed event processing
- Instead of popping events to send before they persist, mark them as in-progress and remove them only once persisted - Check for timed out events in bulk - Eschew locks in favour of DB-level atomicity
-
-
-
Commits on Aug 29, 2024
-
Merge 'develop' & bump schema version
Bump the schema version for delayed events to 88, to avoid conflict with schema version 87 for sliding sync
Commits on Sep 9, 2024
Commits on Sep 10, 2024
-
Nitpick: rename inner function
Remove leading underscore for consistency with other inner functions
-
-
Commits on Sep 11, 2024
-
Put retrieved delayed events in field for GET
This is to match what is specified in the MSC. Also add a unit test for this.
-
-
Don't use data-modifying CTE in WITH for sqlite
Also don't try to use ordered RETURNING rows for sqlite either
-
Remove TODO for returning transaction IDs
GET /delayed_events is no longer specced to return them
-
Commits on Sep 13, 2024
-
-
-
-
Don't expect to remember next_send_ts
See DelayedEventsHandler._next_send_ts_changed for details
-
-
-
Commits on Sep 16, 2024
-
Use default ts for delayed events sent on request
When a delayed event is sent on-demand, let its timestamp be set to whatever time the event is sent at, like non-delayed events. Only timed-out delayed events should have their timestamps set to their timeout time, as that is the time they are meant to be sent.
-
as it converts fields (namely RoomIDs) to dicts too
-
Fix path regex for delayed_events updating
Require non-empty delay ID in path
-