Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support & use stable endpoints for MSC4151 #17374

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Support & use stable endpoints for MSC4151 #17374

merged 8 commits into from
Oct 31, 2024

Conversation

turt2live
Copy link
Member

matrix-org/matrix-spec-proposals#4151 has finished FCP.

See #17373 for unstable endpoint removal

@turt2live turt2live marked this pull request as ready for review June 29, 2024 00:08
@turt2live turt2live requested a review from a team as a code owner June 29, 2024 00:08
anoadragon453
anoadragon453 reviewed Jul 1, 2024
View reviewed changes
synapse/rest/client/reporting.py Outdated Show resolved Hide resolved
synapse/rest/client/reporting.py Outdated Show resolved Hide resolved
@anoadragon453 anoadragon453 removed their request for review July 15, 2024 13:32
@turt2live turt2live requested a review from a team October 30, 2024 18:33
@Cynn1989 Cynn1989 mentioned this pull request Oct 31, 2024
Closed
anoadragon453
anoadragon453 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I briefly questioned whether we should still gate the unstable endpoint behind an experimental feature flag, but it makes sense to keep that endpoint around only for those that were playing with the experimental feature.

@anoadragon453 anoadragon453 merged commit c705bee into develop Oct 31, 2024
39 checks passed
@anoadragon453 anoadragon453 deleted the travis/report-room-stable branch October 31, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @anoadragon453