Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #17657

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 3, 2024

Bumps actions/download-artifact from 3 to 4.1.7.

Release notes

Sourced from actions/download-artifact's releases.

v4.1.7

What's Changed

Full Changelog: actions/download-artifact@v4.1.6...v4.1.7

v4.1.6

What's Changed

Full Changelog: actions/download-artifact@v4.1.5...v4.1.6

v4.1.5

What's Changed

Full Changelog: actions/download-artifact@v4.1.4...v4.1.5

v4.1.4

What's Changed

Full Changelog: actions/download-artifact@v4...v4.1.4

v4.1.3

What's Changed

New Contributors

Full Changelog: actions/download-artifact@v4...v4.1.3

v4.1.2

v4.1.1

v4.1.0

What's Changed

... (truncated)

Commits
  • 65a9edc Merge pull request #325 from bethanyj28/main
  • fdd1595 licensed
  • c13dba1 update @​actions/artifact dependency
  • 0daa75e Merge pull request #324 from actions/eggyhead/use-artifact-v2.1.6
  • 9c19ed7 Merge branch 'main' into eggyhead/use-artifact-v2.1.6
  • 3d3ea87 updating license
  • 89af5db updating artifact package v2.1.6
  • b4aefff Merge pull request #323 from actions/eggyhead/update-artifact-v215
  • 8caf195 package lock update
  • d7a2ec4 updating package version
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@anoadragon453
Copy link
Member

Our CI workflow specifically has a comment to not upgrade the upload-artifact or download-artifact dependencies to v4+. This is because we were having errors during a release: #16847

It would be worth trying to upgrade again to the latest versions of both dependencies, and test the workflows. Perhaps on the release of v1.115.0 (or rc2 if it exists)?

@anoadragon453 anoadragon453 removed the request for review from a team September 10, 2024 16:58
@anoadragon453
Copy link
Member

anoadragon453 commented Oct 28, 2024

v3 will be deprecated on Nov 30th, 2024, and this action may stop working then, breaking our release process.

@devonh
Copy link
Member

devonh commented Nov 4, 2024

I read through both the upload-artifact and download-artifact changes and I think things should be working in their current state if we update.
I think the best path forward will be to try upgrading again (for v1.119.0rc1) then deal with the fallout if things are still breaking and find a solution that works.

Copy link
Member

@devonh devonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the version bump and will test out in 1.119.0rc1. Will follow up with further fixes if the release is broken.

@devonh devonh merged commit 46bd7e1 into develop Nov 6, 2024
31 checks passed
@devonh devonh deleted the dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7 branch November 6, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants