Add config option redis.password_path #17717
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to load the Redis password from a file, instead of giving it in the config directly. The code is similar to how it’s done for
registration_shared_secret_path
. I changed the example in the documentation to represent the best practice regarding the handling of secrets.Reading secrets from files has the security advantage of separating the secrets from the config. It also simplifies secrets management in Kubernetes.
The second commit adds test cases for secret files existing and missing.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)