Store the `LoggingContext` in a `ContextVar` #18871

MadLittleMods · 2025-08-28T01:06:40Z

This is a first step towards ContextVar based LoggingContext. This PR only goes as far as to store the LoggingContext in a ContextVar instead of thread-local. But this still gives us the benefit of being able to remove the painful log context rule complexity around needing to make sure the thread-local is set correctly as awaitables are suspended and resumed in the Twisted reactor.

Part of #10342 (previously matrix-org/synapse#10342)

This is purely based on @sandhose's branch which I've just picked up, kicked the tires, and brought forward to propose and merge.

This is spawning from adding server_name to the LoggingContext and finding that we use the sentinel LoggingContext in many places (which means the server_name isn't tracked in those places). After removing the sentinel LoggingContext from a few places, it uncovered some places where we don't seem to be following the log context rules so things are getting messed up. Instead of trying to adapt a bunch of tricky areas to follow the rules, I decided to just try removing the need for the log context rules and just refactor to the ContextVar based LoggingContext.

Testing strategy

Run Synapse normally and with daemonize: true: poetry run synapse_homeserver --config-path homeserver.yaml
Execute some requests
Shutdown the server
Look for any bad log entries in your homeserver logs:
- Expected logging context sentinel but found main
- Expected logging context main was lost
- Expected previous context
- utime went backwards!/stime went backwards!
- Called stop on logcontext POST-0 without recording a start rusage

Todo

Update docs/log_contexts.md
Fix failing tests in tests/util/caches/test_descriptors.py (synapse/util/patch_inline_callbacks.py)

Handle log contexts across Rust

For example, this spot says it doesn't handle ContextVars:

synapse/rust/src/http_client.rs

Lines 247 to 251 in c68c5dd

    
           /// Creates a twisted deferred from the given future, spawning the task on the 
        
           /// tokio runtime. 
        
           /// 
        
           /// Does not handle deferred cancellation or contextvars. 
        
           fn create_deferred<'py, F, O>(

Future:

Over time, we can also remove PreserveLoggingContext from many scenarios
- Remove sentinel logcontext where we log in setup, start and exit #18870
Follow-up with a PR to remove make_deferred_yieldable

Dev notes

SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.util.caches.test_descriptors

SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.util.test_logcontext

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct (run the linters)

MadLittleMods · 2025-08-28T01:15:22Z

synapse/logging/context.py

+# TODO: This function is a no-op now and should be removed in a follow-up PR.
 def make_deferred_yieldable(deferred: "defer.Deferred[T]") -> "defer.Deferred[T]":


make_deferred_yieldable no longer does anything (no-op) but there a lot of references to clean-up. I think it would be better to do this in a follow-up PR than bulk up with this diff with changes that will cloud the main change we're trying to introduce.

…matter anymore)

MadLittleMods · 2025-08-28T03:48:31Z

docs/log_contexts.md

+Ideally, nothing from the Synapse homeserver would be logged against the `sentinel`
+context as we want to know where the logs came from. In practice, this is not always the
+case yet especially outside of request handling.


Over time, we can remove PreserveLoggingContext from many scenarios that cause the sentinel context to be used.

I've already started this separately in #18870

…les anymore

MadLittleMods · 2025-09-02T19:09:22Z

synapse/util/patch_inline_callbacks.py

@@ -1,250 +0,0 @@
-#


As far as I can tell, these checks provide no value to us anymore. We don't have specific log rules to worry about anymore and the ContextVar properly follows the context regardless.

MadLittleMods · 2025-09-02T19:10:11Z

tests/util/caches/test_descriptors.py

                    self.assertEqual(
                        current_context(),
-                        SENTINEL_CONTEXT,
+                        c1,


As far as I can tell, these new context values make sense. We're in context c1, so current_context() should be c1.

MadLittleMods · 2025-09-02T19:11:03Z

synapse/__init__.py

-if bool(os.environ.get("SYNAPSE_TEST_PATCH_LOG_CONTEXTS", False)):
-    # We import here so that we don't have to install a bunch of deps when
-    # running the packaging tox test.
-    from synapse.util.patch_inline_callbacks import do_patch
-
-    do_patch()


See #18871 (comment) for why we've removed the patch_inline_callbacks

When we `daemonize`, we fork the process and cputime metrics get confused about the per-thread resource usage appearing to go backwards because we're comparing the resource usage (`rusage`) from the original process to the forked process. We now kick off the background tasks (`run_as_background_process`) after we have forked the process so the `rusage` we record when we `start` is in the same thread when we `stop`. Bad log examples from before: ``` synapse.logging.context - ERROR - _schedule_next_expiry-0 - utime went backwards! 0.050467 < 0.886526 synapse.logging.context - ERROR - _schedule_db_events-0 - stime went backwards! 0.009941 < 0.155106 synapse.logging.context - ERROR - wake_destinations_needing_catchup-0 - stime went backwards! 0.010175 < 0.130923 synapse.logging.context - ERROR - resume_sync_partial_state_room-0 - utime went backwards! 0.052898 < 0.886526 ``` Testing strategy: 1. Run with `daemonize: true` in your `homeserver.yaml` 1. `poetry run synapse_homeserver --config-path homeserver.yaml` 1. Shutdown the server 1. Look for any bad log entries in your homeserver logs: - `Expected logging context sentinel but found main` - `Expected logging context main was lost` - `utime went backwards!`/`stime went backwards!`

MadLittleMods · 2025-09-03T00:04:33Z

synapse/logging/context.py

+    return _current_context.get(SENTINEL_CONTEXT)


 def set_current_context(context: LoggingContextOrSentinel) -> LoggingContextOrSentinel:


TODO: The docstring needs to be updated

MadLittleMods · 2025-09-03T00:22:08Z

synapse/logging/context.py


-_thread_local = threading.local()
-_thread_local.current_context = SENTINEL_CONTEXT
+_current_context: ContextVar[LoggingContextOrSentinel] = ContextVar("current_context")


Error: Called stop on logcontext POST-0 without recording a start rusage

There is a problem where the POST-0 LoggingContext is somehow becoming the current context without a corresponding set_current_context(POST-0) call.

See the lines marked red in the snippet below.

SYNAPSE_TEST_LOG_LEVEL=INFO poetry run trial tests.rest.client.test_rooms.RoomStateTestCase.test_get_state_event_cancellation

_trial_temp/test.log

2025-09-02 19:12:06-0500 [-] synapse.http.site - 304 - INFO - sentinel - asdf SynapseRequest render 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 662 - INFO - sentinel - asdf PreserveLoggingContext(POST-0).__enter__ nonce=meZAG + 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(POST-0) (previous=sentinel) + 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - POST-0 - asdf LoggingContext(POST-0).start usage_start=True + 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 675 - INFO - POST-0 - asdf PreserveLoggingContext(POST-0).__exit__ nonce=meZAG restoring old_context=sentinel + 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - POST-0 - asdf set_current_context(sentinel) (previous=POST-0) + 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - POST-0 - asdf LoggingContext(POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 662 - INFO - sentinel - asdf PreserveLoggingContext(sentinel).__enter__ nonce=xQsLm 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(sentinel) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(_handle_new_device_update_async-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - _handle_new_device_update_async-0 - asdf LoggingContext(_handle_new_device_update_async-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 675 - INFO - sentinel - asdf PreserveLoggingContext(sentinel).__exit__ nonce=xQsLm restoring old_context=sentinel 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(sentinel) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-_handle_new_device_update_async-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-_handle_new_device_update_async-0 - asdf LoggingContext(db-_handle_new_device_update_async-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-_handle_new_device_update_async-0 - asdf set_current_context(sentinel) (previous=db-_handle_new_device_update_async-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-_handle_new_device_update_async-0 - asdf LoggingContext(db-_handle_new_device_update_async-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-_handle_new_device_update_async-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-_handle_new_device_update_async-0 - asdf LoggingContext(db-_handle_new_device_update_async-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-_handle_new_device_update_async-0 - asdf set_current_context(sentinel) (previous=db-_handle_new_device_update_async-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-_handle_new_device_update_async-0 - asdf LoggingContext(db-_handle_new_device_update_async-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - _handle_new_device_update_async-0 - asdf set_current_context(sentinel) (previous=_handle_new_device_update_async-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - _handle_new_device_update_async-0 - asdf LoggingContext(_handle_new_device_update_async-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - sentinel - asdf set_current_context(db-POST-0) (previous=sentinel) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 454 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).start usage_start=True 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - db-POST-0 - asdf set_current_context(sentinel) (previous=db-POST-0) 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - db-POST-0 - asdf LoggingContext(db-POST-0).stop usage_start=True rusage=True - 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 662 - INFO - POST-0 - asdf PreserveLoggingContext(sentinel).__enter__ nonce=JvLjU - 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 723 - INFO - POST-0 - asdf set_current_context(sentinel) (previous=POST-0) - 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 471 - INFO - POST-0 - asdf LoggingContext(POST-0).stop usage_start=False rusage=True - 2025-09-02 19:12:06-0500 [-] synapse.logging.context - 488 - ERROR - POST-0 - asdf Called stop on logcontext POST-0 without recording a start rusage

Perhaps this is a Twisted bug?

I was under the impression that Twisted supported ContextVar's but now I'm not sure. All of the issues mentioned in matrix-org/synapse#10342 are resolved but there are other things in the Twisted tracker:

Unresolved issues:

Support contextvars in Deferred twisted/twisted#9807

[#9807] contextvars support for Deferred twisted/twisted#1262

Support contextvars in DelayedCall twisted/twisted#9824

Resolved issues:

Support Contextvars in coroutines (inlineCallbacks/ensureDeferred) twisted/twisted#9719

[#9719] Support contextvars in coroutines twisted/twisted#1192

Contextvars support does not support .reset twisted/twisted#10301

10301 Fix support for contextvar.reset twisted/twisted#1690

And we could even be running into something unreported 🤷 Need to investigate more.

From some more debugging, I think the ContextVar is acting normally.

And this may just be the case that the LoggingContext start/stop pattern isn't compatible with the ContextVar we're using now. We'd have to maintain the log context rules 🤔.

In this case, it's the SynapseRequest.logcontext where stop is called because we have a PreserveLoggingContext around SynapseRequest.render which only kicks off the render and doesn't wait for it to finish so we stop way before the request is done. And it's never re-started. So when other LoggingContext utilities are used in the downstream code to set_current_context, it will stop the already stopped SynapseRequest.logcontext.

I go back and forth on whether we can update things to work correctly. If I naively try to manage the lifetime myself by calling self.logcontext.__enter__ manually in SynapseRequest.render, it still doesn't work out.

MadLittleMods · 2025-09-05T16:42:41Z

synapse/app/_base.py

+    # Register background tasks required by this server. This must be done
+    # somewhat manually due to the background tasks not being registered
+    # unless handlers are instantiated.
+    if hs.config.worker.run_background_tasks:
+        hs.start_background_tasks()


Split out this change to #18886 since it seems good in any case

And this PR may get stale

Spawning from #18871 [This change](6ce2f3e) was originally used to fix CPU time going backwards when we `daemonize`. While, we don't seem to run into this problem on `develop`, I still think this is a good change to make. We don't need background tasks running on a process that will soon be forcefully exited and where the reactor isn't even running yet. We now kick off the background tasks (`run_as_background_process`) after we have forked the process and started the reactor. Also as simple note, we don't need background tasks running in both halves of a fork.

MadLittleMods · 2025-09-23T17:18:11Z

Closing as I've decided to continue trudging in the LoggingContext logcontext mud (see #18905)

sandhose and others added 2 commits August 27, 2025 19:57

WIP: use a contextvar to store the logcontext

224cb3f

Mark make_deferred_yieldable for future deletion

3742b3b

MadLittleMods added the A-Logging label Aug 28, 2025

Add changelog

4303879

MadLittleMods commented Aug 28, 2025

View reviewed changes

MadLittleMods added 2 commits August 27, 2025 20:27

Remove mentions of Synapse logcontext rules (the distinction doesn't …

0c8759b

…matter anymore)

Rewrite docs and remove log context rules (no longer relevant)

3e66e0a

github-actions bot deployed to PR Documentation Preview August 28, 2025 03:48 Active

MadLittleMods commented Aug 28, 2025

View reviewed changes

MadLittleMods added 2 commits September 2, 2025 13:39

Merge branch 'develop' into madlittlemods/log-context-using-contextvars3

1f384b0

No need to patch_inline_callbacks when we don't have log context ru…

c7a80b6

…les anymore

github-actions bot deployed to PR Documentation Preview September 2, 2025 19:08 Active

MadLittleMods commented Sep 2, 2025

View reviewed changes

Fix lints

93044f4

github-actions bot deployed to PR Documentation Preview September 2, 2025 19:29 Active

github-actions bot deployed to PR Documentation Preview September 2, 2025 20:20 Active

MadLittleMods commented Sep 3, 2025

View reviewed changes

This was referenced Sep 4, 2025

Fix server_name in logging context for multiple Synapse instances in one process #18868

Merged

Start background tasks after we fork the process (daemonize) #18886

Merged

MadLittleMods commented Sep 5, 2025

View reviewed changes

MadLittleMods closed this Sep 23, 2025

MadLittleMods mentioned this pull request Oct 1, 2025

ContextVar with tracing breaks responses #19004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Store the `LoggingContext` in a `ContextVar` #18871

Store the `LoggingContext` in a `ContextVar` #18871

Uh oh!

MadLittleMods commented Aug 28, 2025 •

edited

Loading

Uh oh!

MadLittleMods Aug 28, 2025

Uh oh!

MadLittleMods Aug 28, 2025

Uh oh!

MadLittleMods Sep 2, 2025

Uh oh!

MadLittleMods Sep 2, 2025

Uh oh!

MadLittleMods Sep 2, 2025

Uh oh!

MadLittleMods Sep 3, 2025

Uh oh!

MadLittleMods Sep 3, 2025 •

edited

Loading

Uh oh!

MadLittleMods Sep 3, 2025 •

edited

Loading

Uh oh!

MadLittleMods Sep 4, 2025 •

edited

Loading

Uh oh!

MadLittleMods Sep 5, 2025

Uh oh!

MadLittleMods commented Sep 23, 2025

Uh oh!

Uh oh!

	/// Creates a twisted deferred from the given future, spawning the task on the
	/// tokio runtime.
	///
	/// Does not handle deferred cancellation or contextvars.
	fn create_deferred<'py, F, O>(

		# TODO: This function is a no-op now and should be removed in a follow-up PR.
		def make_deferred_yieldable(deferred: "defer.Deferred[T]") -> "defer.Deferred[T]":

		return _current_context.get(SENTINEL_CONTEXT)


		def set_current_context(context: LoggingContextOrSentinel) -> LoggingContextOrSentinel:

Store the LoggingContext in a ContextVar #18871

Store the LoggingContext in a ContextVar #18871

Uh oh!

Conversation

MadLittleMods commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing strategy

Todo

Dev notes

Pull Request Checklist

Uh oh!

MadLittleMods Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Error: Called stop on logcontext POST-0 without recording a start rusage

Uh oh!

MadLittleMods Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

MadLittleMods commented Sep 23, 2025

Uh oh!

Uh oh!

Store the `LoggingContext` in a `ContextVar` #18871

Store the `LoggingContext` in a `ContextVar` #18871

MadLittleMods commented Aug 28, 2025 •

edited

Loading

MadLittleMods Sep 3, 2025 •

edited

Loading

Error: `Called stop on logcontext POST-0 without recording a start rusage`

MadLittleMods Sep 3, 2025 •

edited

Loading

MadLittleMods Sep 4, 2025 •

edited

Loading