Add experimental support for MSC4360: Sliding Sync Threads Extension #19005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonh
commented
Oct 3, 2025
| ) -> JsonDict: | ||
| """Get related events of a event, ordered by topological ordering. | ||
| TODO Accept a PaginationConfig instead of individual pagination parameters. |
There was a problem hiding this comment.
This has been done alread, the comment just wasn't updated.
devonh
commented
Oct 3, 2025
Comment on lines
+1202
to
+1217
| WHERE EXISTS ( | ||
| SELECT 1 | ||
| FROM room_memberships AS rm | ||
| WHERE rm.room_id = threads.room_id | ||
| AND rm.user_id = ? | ||
| AND rm.event_stream_ordering <= threads.stream_ordering | ||
| AND rm.membership = ? | ||
| AND NOT EXISTS ( | ||
| SELECT 1 | ||
| FROM room_memberships AS rm2 | ||
| WHERE rm2.room_id = rm.room_id | ||
| AND rm2.user_id = rm.user_id | ||
| AND rm2.event_stream_ordering > rm.event_stream_ordering | ||
| AND rm2.event_stream_ordering <= threads.stream_ordering | ||
| ) | ||
| ) |
There was a problem hiding this comment.
I think this does what the comment says. That is to check if there exists a "join" membership event for this user in this room that is the latest membership event prior to the thread event stream_ordering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: matrix-org/matrix-spec-proposals#4360
Disclaimer: I used Claude Code in a consultative manner to assist with parts of this PR.
I used it mainly for considering options for the SQL query and to generate test cases.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.