Run trial tests on Python 3.14 in PRs #19135
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
approved these changes
Nov 6, 2025
| @@ -0,0 +1 @@ | |||
| Run trial tests on Python 3.14 for PRs. No newline at end of file | |||
Comment on lines
+38
to
+41
| # For PRs, we only run each type of test with the oldest and newest Python | ||
| # version that's supported. The oldest version ensures we don't accidentally | ||
| # introduce syntax or code that's too new, and the newest ensures we don't use | ||
| # code that's been dropped in the latest supported Python version. |
| for version in ("3.11", "3.12", "3.13") | ||
| ) | ||
|
|
||
| trial_postgres_tests = [ |
Contributor
There was a problem hiding this comment.
I guess we have to assume the reason but we don't run all Python versions for Postgres is just to reduce expense? (we could at-least comment that assumption for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by #19132 being caught after the fact, rather than during review of #19055.
This adds two extra CI runs to each PR, with the benefit of catching places where we may introduce code that's incompatible with the latest Python version (but is compatible with the oldest).
To reduce the cost, we may want to only run the postgres Python 3.14 trial CI job on PRs, instead of both sqlite and postgres. This is because more tests are run on the postgres variant. Either the sqlite or postgres variant would have caught #19132.
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.