Ele 4028 format alerts messages #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @MikaKerman |
MikaKerman
force-pushed
the
ele-4028-send-alerts-messages
branch
from
e23e40d to
7baf655
Compare
- Implemented `test_alert_message.py` with functions to generate structured alert messages for dbt tests - Created utility functions to handle alert status, colors, and message block generation - Added comprehensive test suite in `test_dbt_test_alert_message.py` to validate message body generation - Updated `messages/utils.py` to improve JSON comparison in unit tests
- Implemented `get_elementary_test_alert_message_body()` in `test_alert_message.py` to generate structured alert messages for Elementary tests - Added support for different test types like schema changes and anomaly detection - Created comprehensive test suite in `test_elementary_test_alert_message.py` to validate message body generation - Introduced utility functions to handle test alert titles and result blocks - Updated test fixtures and utility functions to support new alert message generation
- Implemented `get_snapshot_alert_message_body()` in `test_alert_message.py` to generate structured alert messages for snapshot alerts - Updated utility functions like `get_details_blocks()` and `get_result_blocks()` to support snapshot alert message generation - Added comprehensive test suite in `test_snapshot_alert_message.py` to validate snapshot alert message body generation - Introduced flexible message generation that handles various alert scenarios with optional fields
- Implemented `get_model_alert_message_body()` in `test_alert_message.py` to generate structured alert messages for model alerts - Added `get_model_alert_config_blocks()` to support model-specific configuration details - Created comprehensive test suite in `test_model_alert_message.py` to validate model alert message body generation - Updated test utilities to support model alert message generation with various scenarios
- Implemented `get_source_freshness_alert_message_body()` in `test_alert_message.py` to generate structured alert messages for source freshness alerts - Added `get_source_freshness_alert_config_blocks()` to support source freshness-specific configuration details - Updated utility functions to include new status types and additional information blocks - Created comprehensive test suite in `test_source_freshness_alert_message.py` to validate source freshness alert message body generation
- Implemented `get_alerts_group_message_body()` in `test_alert_message.py` to generate structured alert messages for groups of alerts - Added new utility functions `get_alert_type_counters_subtitle_block()`, `get_alert_list_line()`, and `get_alert_list_blocks()` to support alerts group message generation - Created comprehensive test suite in `test_alerts_group_message.py` to validate alerts group message body generation - Supports multiple alert types including model errors, test failures, test warnings, and test errors - Handles alerts with different ownership and optional report links
…arios - Added support for handling alerts without a consistent model unique ID - Implemented fallback summary generation when no model is available - Added new properties to aggregate tags, owners, and subscribers across alerts - Improved null-safety and type handling for model and summary properties
- Implemented `get_group_by_table_alert_message_body()` in `test_alert_message.py` to generate structured alert messages for alerts grouped by table - Created comprehensive test suite in `test_group_by_table_alert_message.py` to validate group by table alert message body generation - Updated utility functions to support sorting and displaying owners consistently - Added support for generating messages with various alert types and configurations
…bscribers - Added fallback text for empty lists to ensure consistent message formatting
…t message generation
MikaKerman
force-pushed
the
ele-4028-send-alerts-messages
branch
from
c14fda0 to
a37d0a2
Compare
…nction to return `None` when input status is `None`
- Modify function to remove duplicate entries for tags, owners, and subscribers
MikaKerman
force-pushed
the
ele-4028-send-alerts-messages
branch
2 times, most recently
from
05d0a36 to
86f5b24
Compare
ofek1weiss
reviewed
Feb 4, 2025
| facts = [] | ||
| if materialization: | ||
| facts.append(("Materialization", materialization)) | ||
| if full_refresh: |
There was a problem hiding this comment.
if full_refresh is not None
| if len(owners) == 1: | ||
| inlines.append(TextBlock(text=f"Owner: {owners.pop()}")) | ||
| else: | ||
| # order owners by alphabetical order |
There was a problem hiding this comment.
redundant comment is redundant
- Introduced `AlertMessageBuilder` class in `builder.py` to consolidate alert message generation logic - Replaced multiple individual message generation functions with a single, flexible `build()` method - Updated test utilities to use the new `get_alert_message_body()` function with the `AlertMessageBuilder` - Removed the deprecated `test_alert_message.py` file - Maintained existing functionality while improving code organization and reusability
- Introduced `PrimaryFactBlock()` and `NonPrimaryFactBlock()` functions to create fact blocks with configurable primary status - Simplified fact block creation by extracting common logic into a shared implementation - Supports creating fact blocks with flexible title and value configurations
MikaKerman
force-pushed
the
ele-4028-send-alerts-messages
branch
from
3bbd7d8 to
ba19e7c
Compare
… placement - Add divider blocks between different alert type sections - Ensure clean separation of model errors, test failures, test warnings, and test errors - Modify block extension logic to maintain a clear and organized alert message structure
…de test combinations - Removed `itertools.product()` and global test parameter lists from multiple test files - Replaced dynamic parameter generation with explicit, predefined test combinations - Simplified test parameter generation while maintaining comprehensive test coverage - Improved readability by removing unnecessary imports and global variables - Formatted adaptive card filename generation for better consistency across test files
|
@ofek1weiss I have reduced the number of test cases. |
- Introduced `DEFAULT_ENV` constant with value "dev" - Updated `Config` class constructor to use `DEFAULT_ENV` as default environment - Added `specified_env` property to return environment only if it differs from default
- Updated alert model classes to include an optional `env` parameter - Modified alert data schemas to pass the `env` parameter during alert model creation - Integrated environment specification in data monitoring alerts generation
- Updated `BaseAlertsGroup` and `AlertsGroup` to include an optional `env` parameter - Modified `DataMonitoringAlerts` to pass environment when creating grouped alerts - Updated base integration to propagate environment when grouping alerts - Ensures environment context is preserved across alert processing and grouping
- Added environment parameter to test cases for various alert message types - Modified test file names to include environment flag - Updated test utilities to conditionally set environment in test alerts - Ensured comprehensive test coverage for alerts with and without environment context
|
@ofek1weiss |
MikaKerman
changed the title
- Refactored subtitle block generation for different alert types into a single method - Simplified type checking and block creation for test, model, snapshot, and source alerts - Reduced code duplication by using a unified approach to generate subtitle blocks
ofek1weiss
approved these changes
Feb 6, 2025
- Updated test files to use UTC timezone for datetime objects - Imported `timezone` from `datetime` in alert message test files - Ensured consistent timezone handling across different alert message test scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null