Ele 4029 slack message blocks #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-4029-slack-message-blocks
|
👋 @ofek1weiss |
ofek1weiss
commented
Feb 4, 2025
| @@ -10,28 +10,13 @@ | |||
|
|
|||
There was a problem hiding this comment.
moved all test logic to base_test_format.py
ofek1weiss
commented
Feb 4, 2025
| @@ -0,0 +1,327 @@ | |||
| from abc import abstractmethod | |||
There was a problem hiding this comment.
adapted from test_adaptive_cards.py
MikaKerman
approved these changes
Feb 9, 2025
| secondary_facts.append(current_fact) | ||
| self._add_secondary_facts(secondary_facts) | ||
|
|
||
| def _add_divider_block(self, block: DividerBlock) -> None: |
There was a problem hiding this comment.
Is it necessary to get the block?
There was a problem hiding this comment.
its not necessary, but it think it makes more sense for this function to decide that it isn't
|
@ofek1weiss What about adding tests to the alerts message builder? |
The message builder did not exist at the time, will do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null