Silence some minor compile warnings (#2211)

* Handle error * Explicit .begin * Resolve name clash * Handle AppStream.IconKind.REMOTE
elementary · Sep 16, 2024 · 8816fde · 8816fde
1 parent 0818c32
commit 8816fde
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/src/Core/Package.vala b/src/Core/Package.vala
@@ -676,6 +676,10 @@ public class AppCenterCore.Package : Object {
                 case AppStream.IconKind.UNKNOWN:
                     warning ("'%s' is an unknown kind of AppStream icon", _icon.get_name ());
                     break;
+
+                case AppStream.IconKind.REMOTE:
+                    warning ("'%s' is a remote AppStream icon", _icon.get_name ());
+                    break;
             }
         }
 

diff --git a/src/Core/UpdateManager.vala b/src/Core/UpdateManager.vala
@@ -151,7 +151,10 @@ public class AppCenterCore.UpdateManager : Object {
         runtime_updates.update_state ();
 
         if (AppCenter.App.settings.get_boolean ("automatic-updates")) {
-            yield update_all (cancellable);
+            try {
+                yield update_all (cancellable);
+            } catch (Error e) {} // update_all () already logs error message
+            //TODO Should we send a notification that automatic-updates had an error?
         } else {
             var application = Application.get_default ();
             if (updates_number > 0) {
@@ -293,7 +296,7 @@ public class AppCenterCore.UpdateManager : Object {
             return GLib.Source.REMOVE;
         });
 
-        get_updates (cancellable);
+        get_updates.begin (cancellable);
     }
 
     private int compare_package_func (Object object1, Object object2) {

diff --git a/src/Widgets/Banner.vala b/src/Widgets/Banner.vala
@@ -30,15 +30,15 @@ public class AppCenter.Widgets.Banner : Gtk.Button {
     public Icon icon { get; construct; }
     public string brand_color { get; construct; }
     public string description { get; construct; }
-    public string name { get; construct; }
+    public string app_name { get; construct; }
     public string summary { get; construct; }
 
     public Banner (string name, string summary, string description, Icon icon, string brand_color) {
         Object (
             brand_color: brand_color,
             description: description,
             icon: icon,
-            name: name,
+            app_name: name,
             summary: summary
         );
     }
@@ -58,7 +58,7 @@ public class AppCenter.Widgets.Banner : Gtk.Button {
 
 
     construct {
-        var name_label = new Gtk.Label (name) {
+        var name_label = new Gtk.Label (app_name) {
             max_width_chars = 50,
             use_markup = true,
             wrap = true,