-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Gtk 4 #1896
Port to Gtk 4 #1896
Conversation
@leolost2605 since AppCenter is somewhere you touched recently could I get a review here? I'd like to do some more UI work but I really want to land GTK4 porting first :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things I noticed during testing, I think most of them aren't blocking though
-
If you've got only a few packages the packages grid in the update view is bottom aligned but I think that's also present in master
-
The backbutton doesn't have the back style applied but I've seen the same thing in settings so I think that's a granite/stylesheet issue?
-
Switching between remotes plays an leaflet animation
-
There are a lot of deprecation warnings but I guess those can be fixed in follow up PRs
Yup that's in master too. Definitely wanna iterate here in a future branch
Ah because widgets are visible by default in GTK4 and we forgot to remove this when we removed the updates recently in another branch. Fixed!
Yeah, pushed a fix to stylesheet 😅
Yeah this might be a leaflet problem 🤔 When we move to NavigationView there's a property there for disabling animations, but I was trying to keep from blowing up the diff. Is this okay to fix in a follow up?
Yeah I was trying to keep the diff here as small as I can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good enough to iterate on! 🎉
Let's fucking goooo |
Fixes #1590
Fixes #1795
Fixes #1940
I've tried to comment all non-obvious changes here. A lot of the diff is just minor API changes. Hide whitespace changes might be useful since there's a few try/catches removed or null or type checks added
Categories:
Application:
close
Package:
StripeDialog:
activates_default
so use a key controllerprimary_icon_name
so parent a Gtk.ImageMainWindow:
AppInfoView:
AbstractAppContainer: