Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job: add to_string method to Job.Type #2182

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Job: add to_string method to Job.Type #2182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d5d96
Job: add to_string method to Job.Type
danirabbit Jun 20, 2024
4d7614f
merge main
danirabbit Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/Core/Job.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,34 @@ public class AppCenterCore.Job : Object {
GET_PACKAGE_DETAILS,
GET_PACKAGE_DEPENDENCIES,
GET_PREPARED_PACKAGES,
REPAIR,
REPAIR;

public string to_string () {
switch (this) {
case GET_DETAILS_FOR_PACKAGE_IDS:
case GET_PACKAGE_DEPENDENCIES:
case GET_PACKAGE_DETAILS:
case IS_PACKAGE_INSTALLED:
return _("Getting app information…");
case GET_DOWNLOAD_SIZE:
return _("Getting download size…");
case GET_PREPARED_PACKAGES:
case GET_INSTALLED_PACKAGES:
case GET_UPDATES:
case REFRESH_CACHE:
return _("Checking for updates…");
case INSTALL_PACKAGE:
return _("Installing…");
case UPDATE_PACKAGE:
return _("Installing updates…");
case REMOVE_PACKAGE:
return _("Uninstalling…");
case REPAIR:
return _("Repairing…");
}

return "";
}
}

public Job (Type type) {
Expand Down
36 changes: 2 additions & 34 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {
backend.bind_property ("working", overlaybar, "active", GLib.BindingFlags.SYNC_CREATE);

backend.notify ["job-type"].connect (() => {
update_overlaybar_label (backend.job_type);
overlaybar.label = backend.job_type.to_string ();
});

notify["working"].connect (() => {
Expand All @@ -54,7 +54,7 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {
});
});

update_overlaybar_label (backend.job_type);
overlaybar.label = backend.job_type.to_string ();
}

construct {
Expand Down Expand Up @@ -258,36 +258,4 @@ public class AppCenter.MainWindow : Gtk.ApplicationWindow {
show_package (package);
});
}

private void update_overlaybar_label (AppCenterCore.Job.Type job_type) {
switch (job_type) {
case GET_DETAILS_FOR_PACKAGE_IDS:
case GET_PACKAGE_DEPENDENCIES:
case GET_PACKAGE_DETAILS:
case IS_PACKAGE_INSTALLED:
overlaybar.label = _("Getting app information…");
break;
case GET_DOWNLOAD_SIZE:
overlaybar.label = _("Getting download size…");
break;
case GET_PREPARED_PACKAGES:
case GET_INSTALLED_PACKAGES:
case GET_UPDATES:
case REFRESH_CACHE:
overlaybar.label = _("Checking for updates…");
break;
case INSTALL_PACKAGE:
overlaybar.label = _("Installing…");
break;
case UPDATE_PACKAGE:
overlaybar.label = _("Installing updates…");
break;
case REMOVE_PACKAGE:
overlaybar.label = _("Uninstalling…");
break;
case REPAIR:
overlaybar.label = _("Repairing…");
break;
}
}
}
Loading