Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner: create providers for display #2207

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

danirabbit
Copy link
Member

Fixes deprecated adding provider to style context

If a brand color is available, creates a style provider with a css class for that color and adds it to a list of providers. Doesn't add a provider if no brand color available. Re-uses providers if two apps use the same brand color

@danirabbit danirabbit requested a review from a team August 29, 2024 23:01
Copy link
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This differs from main for applications that have not set a custom background (?) e.g. Image Optimizer. For these, the banner has no background color whereas in main it uses the user's accent color.

@danirabbit
Copy link
Member Author

@jeremypw is this different from what you're seeing?

Screenshot from 2024-12-09 17 32 09
Screenshot from 2024-12-09 17 32 56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants