When navigating to a new page using "shift + arrow-key" the focus isn't set #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fs3o5 This issue seems to be fixed in master now - could you confirm whether this PR is still needed? |
|
Looks like the issue has reappeared and this PR fixes it so I will review the code and merge if possible. |
|
@fs3o5 The PR needs updating to fully fix the linked issue. If you are unable to continue to work on this I am happy to complete it for you. |
|
Closing in favour of #585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #584
At the moment the focus isn't updated when switching pages with "shift + arrow-key" making the whole navigation method useless.
With this PR the focus is updated, when navigating with "Shift + arrow-key".