Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbol filter to outline pane #1253

Merged
merged 32 commits into from
Aug 2, 2024
Merged

Add symbol filter to outline pane #1253

merged 32 commits into from
Aug 2, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 24, 2023

The is a speculative step towards fixing issues such as #933, #809 and generally increasing the utility of the symbol pane over just searching the text.

  • Add a toolbar header
  • Search Entry in toolbar (currently only search within)
    • Option to search start only (?)
  • Add Filter menu
    • Add SymbolType enum and classify Vala and C symbols with symbol type
    • Allow filtering by symbol type
    • Add Action bar to popover for bulk select/deselect filter options
    • Better icon for filter menu?
  • Choosing e.g. "method" should automatically choose "class" (or "class" always included in filter?)

Note: To show class methods both the "Class" and "Methods" selections must be active.

No filtering:

Screenshot from 2023-03-21 11 55 57

Filtering class properties

Screenshot from 2023-03-21 11 56 27

Searching for text "filter"

Screenshot from 2023-03-21 11 57 24

@jeremypw jeremypw marked this pull request as ready for review January 24, 2023 16:39
@jeremypw jeremypw marked this pull request as draft January 24, 2023 16:50
@jeremypw
Copy link
Collaborator Author

Regression found in global search - investigating.

@jeremypw
Copy link
Collaborator Author

Looks like the regression is due to recent changes to master 😞 not this PR.

@jeremypw
Copy link
Collaborator Author

Regression now fixed by #1254. Leaving this as draft as that PR should be prioritised.

@jeremypw jeremypw marked this pull request as ready for review March 21, 2023 10:09
@jeremypw jeremypw changed the title Add toolbar to outline pane Add symbol filter to outline pane Mar 21, 2023
@jeremypw jeremypw requested a review from a team March 21, 2023 12:00
zeebok
zeebok previously approved these changes May 12, 2023
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to work as intended!

@jeremypw jeremypw requested a review from a team May 12, 2023 09:16
@jeremypw
Copy link
Collaborator Author

@danirabbit Is this something worth progressing? I wasn't sure what icon should be used for the "Select all" button (or whether such a button is needed)

@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Aug 2, 2023
@jeremypw jeremypw marked this pull request as draft August 2, 2023 14:22
# Conflicts fixed:
#	src/SymbolPane/C/CtagsSymbol.vala
#	src/SymbolPane/SymbolOutline.vala
#	src/SymbolPane/Vala/ValaSymbolItem.vala
#	src/Widgets/DocumentView.vala
@jeremypw jeremypw marked this pull request as ready for review July 17, 2024 19:28
@jeremypw jeremypw requested a review from danirabbit July 17, 2024 19:28
@danirabbit
Copy link
Member

@jeremypw sorry for taking a while to follow up on this! I pushed a commit with the filter icon we're using in Mail and fixing the sidebar background styles.

I think for the popover I would just a regular menu here and use regular text menu items for the "select all" and "deselect" all items since those are probably more clearly communicated with text and we're not particularly constrained for space in a menu

@danirabbit danirabbit removed the Needs Design Waiting for input from the UX team label Jul 25, 2024
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected afaict. Nice job :)

@jeremypw jeremypw merged commit 28a063c into master Aug 2, 2024
6 checks passed
@jeremypw jeremypw deleted the search-symbols branch August 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants