Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tab settings #1347

Merged
merged 7 commits into from
Jul 11, 2023
Merged

Sync tab settings #1347

merged 7 commits into from
Jul 11, 2023

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jul 7, 2023

Fixes #1340

  • Ensure the settings, appmenu preferences, format bar and tab popover stay in sync and are applied to doc when editorconfig not overriding
  • Allow overriding tab width and tab style separately
  • Ensure correct settings displayed and used when switching documents while editorconfig active.
  • Ensure correct symbol used when drawing spaces when switching between spaces and tabs

There is a pre-existing issue that the range of the tab width spinbutton is up to 24 while the maximum tab width set by editorconfig plugin is 16. This should be resolved here or later.

As this PR changes a plugin, it needs to be installed for testing.

@jeremypw jeremypw requested a review from a team July 7, 2023 09:45
src/Widgets/FormatBar.vala Outdated Show resolved Hide resolved
zeebok
zeebok previously approved these changes Jul 9, 2023
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as advertised. Besides my one question I think this is good to merge.

@jeremypw
Copy link
Collaborator Author

@zeebok I have removed the clamp as you suggested and added a corresponding forced range to the schema. Also changed the range in the plugin to correspond.

@jeremypw
Copy link
Collaborator Author

I notice that gedit only allows tabs in the range 2 - 8 and also only even numbers.

Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that gedit only allows tabs in the range 2 - 8 and also only even numbers.

Even seems nice but I don't feel strongly enough to not approve this. I think this is great and good customization.

@jeremypw jeremypw merged commit 380240e into master Jul 11, 2023
@jeremypw jeremypw deleted the sync-tab-settings branch July 11, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab width menu at the top doesn´t work
2 participants