-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync tab settings #1347
Sync tab settings #1347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as advertised. Besides my one question I think this is good to merge.
@zeebok I have removed the clamp as you suggested and added a corresponding forced range to the schema. Also changed the range in the plugin to correspond. |
I notice that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that
gedit
only allows tabs in the range 2 - 8 and also only even numbers.
Even seems nice but I don't feel strongly enough to not approve this. I think this is great and good customization.
Fixes #1340
There is a pre-existing issue that the range of the tab width spinbutton is up to 24 while the maximum tab width set by editorconfig plugin is 16. This should be resolved here or later.
As this PR changes a plugin, it needs to be installed for testing.