Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve show_replace action #1374

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Improve show_replace action #1374

merged 3 commits into from
Nov 30, 2023

Conversation

jeremypw
Copy link
Collaborator

Fixes #1371

  • Use selected text as search term
  • Focus replace entry

zeebok
zeebok reviewed Nov 12, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I am going to test this out for a bit on my main machine and let you know!

@zeebok
Copy link
Contributor

zeebok commented Nov 17, 2023

So far this is exactly what I would expect and I am really loving it!

zeebok
zeebok approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am inclined to approve this. The behavior fits intuitively for me but i am curious what your thoughts are on this.

@jeremypw jeremypw merged commit b6dcbbb into master Nov 30, 2023
6 checks passed
@jeremypw jeremypw deleted the fix-replace-shortcut branch November 30, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlighted text isn't used with Ctrl-R shortcut
2 participants
@jeremypw @zeebok