-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command-line "Go-To-Line" option #1382
Add command-line "Go-To-Line" option #1382
Conversation
As long as they haven't already opened/restored
@colinkiama Just a hint - for a substantial PR, if it is ready for review then its best to request a review either from a specific person or from the elementary/desktop-developers team (if you are able to do that). |
Just had a quick try of this - the commandline handling seems to work but the actual selecting and displaying the specified range does not seem to work yet? Maybe convert to draft if you are still working on this. |
I don't have the option to request a reviewer on this PR sadly: |
I'm sure that I completed this. Do you mind sharing what you wrote in the terminal to try out this feature? EDIT io.elementary.code -g 12-20 /home/colinkiama/Projects/files/meson.build |
Ah, I guess you have to be given that permission by @danirabbit . If you contribute regularly (which you seem to be doing) then that should not be a problem 😄 |
Strange - just tried it again and it worked this time. Not sure what happened before - I'll do some more testing and review the coding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of elementaryos code-style suggestions and one suggestion to avoid unnecessary multiple function returns. Should be ready then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go now, thanks for your work!
Fixes #415