Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command-line "Go-To-Line" option #1382

Merged
merged 15 commits into from
Nov 28, 2023

Conversation

colinkiama
Copy link
Member

Fixes #415

@jeremypw
Copy link
Collaborator

@colinkiama Just a hint - for a substantial PR, if it is ready for review then its best to request a review either from a specific person or from the elementary/desktop-developers team (if you are able to do that).

@jeremypw
Copy link
Collaborator

Just had a quick try of this - the commandline handling seems to work but the actual selecting and displaying the specified range does not seem to work yet? Maybe convert to draft if you are still working on this.

@colinkiama
Copy link
Member Author

@colinkiama Just a hint - for a substantial PR, if it is ready for review then its best to request a review either from a specific person or from the elementary/desktop-developers team (if you are able to do that).

I don't have the option to request a reviewer on this PR sadly:
Screenshot from 2023-11-26 15 12 19

@colinkiama
Copy link
Member Author

colinkiama commented Nov 26, 2023

Just had a quick try of this - the command line handling seems to work but the actual selecting and displaying the specified range does not seem to work yet? Maybe convert to draft if you are still working on this.

I'm sure that I completed this. Do you mind sharing what you wrote in the terminal to try out this feature?

EDIT
For example this selected all lines between line 12 and 20 for me:

io.elementary.code -g 12-20 /home/colinkiama/Projects/files/meson.build 

@jeremypw
Copy link
Collaborator

@colinkiama Just a hint - for a substantial PR, if it is ready for review then its best to request a review either from a specific person or from the elementary/desktop-developers team (if you are able to do that).

I don't have the option to request a reviewer on this PR sadly

Ah, I guess you have to be given that permission by @danirabbit . If you contribute regularly (which you seem to be doing) then that should not be a problem 😄

@jeremypw jeremypw self-assigned this Nov 27, 2023
@jeremypw
Copy link
Collaborator

Just had a quick try of this - the command line handling seems to work but the actual selecting and displaying the specified range does not seem to work yet? Maybe convert to draft if you are still working on this.

I'm sure that I completed this. Do you mind sharing what you wrote in the terminal to try out this feature?

Strange - just tried it again and it worked this time. Not sure what happened before - I'll do some more testing and review the coding.

Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of elementaryos code-style suggestions and one suggestion to avoid unnecessary multiple function returns. Should be ready then.

src/Services/LocationJumpManager.vala Outdated Show resolved Hide resolved
src/Application.vala Outdated Show resolved Hide resolved
src/Widgets/SourceView.vala Outdated Show resolved Hide resolved
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now, thanks for your work!

@jeremypw jeremypw merged commit 723348c into elementary:master Nov 28, 2023
6 checks passed
@colinkiama colinkiama deleted the command-line-go-to-line branch January 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose "Go To Line" feature externally
2 participants