Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement default build directory setting #1415

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Jan 24, 2024

This PR allows the setting of a global default build directory (relative to the root of projects) so that when the path of the terminal pane is changed by manually selecting the active project or using the ProjectFolderItem context menu, the desired build location within the project is automatically used.

Screenshot from 2024-01-24 18 48 32

Copy link
Member

@colinkiama colinkiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Except for one thing: The "Open In Terminal Pane" keyboard shortcut (CTRL + ALT + SHIFT + T) doesn't use the default build directory.

@jeremypw
Copy link
Collaborator Author

jeremypw commented Jan 25, 2024

@colinkiama Oops - forgot that. Now fixed 😄

Ideally we want to be able to override the default on a per project basis because e.g. a Flatpak project will have a different default to a native project but we can iterate on this simple implementation. We would need to implement per project settings.

Copy link
Member

@colinkiama colinkiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. it's all fixed now! 👍️

@colinkiama colinkiama merged commit d58da2f into master Jan 25, 2024
6 checks passed
@colinkiama colinkiama deleted the jeremypw/default-build-dir-setting branch January 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants