FolderManager: use git emblem icons #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would probably be better to have it embedded within Code as it is not part of the FD.o standard |
|
otherwise this looks good! |
|
Can these icons be made available in Granite as both Code and Files use them and already have that dependency? |
|
Honestly it might be kinda niche for Granite, but resourced here in the latest commit! |
jeremypw
previously approved these changes
Sep 5, 2024
|
Oops - seems to be a problem with CI - but otherwise approve. |
|
@jeremypw looks like I had made a typo 😅 should be ready to re-review |
jeremypw
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1462
These were added to icons several years ago elementary/icons#1025