Cloning: Show progress in sidebar #1641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: The "Revert shortcut clash" commit was included in error and reverted. It belongs in #1640. |
|
Just noticed the issue also mentioned sending a notification if the window is not focused. This PR does not implement that at present - it is targeted on the toast aspect. |
|
Now implemented notification if not focused. Do we need to withdraw notification (like Terminal) if Code window becomes active? It did not seem necessary to add an action to the notification - when clicked the sending app was focused anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1628
During cloning the dialog hides and a spinner appears in the sidebar. On a successful clone a toast appears in the sidebar. If the clone is unsuccessful the behaviour is as before.