Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help action linked to Github wiki #875

Closed
wants to merge 2 commits into from
Closed

Add help action linked to Github wiki #875

wants to merge 2 commits into from

Conversation

jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Sep 6, 2020

Fixes #874

A page has been added to the wiki listing the available shortcuts. A link to StackExchange questions on Code has also been added to the wiki homepage.

@danirabbit
Copy link
Member

I would really prefer not to send users to the web. Especially since this page will likely not stay up to date with the code base.

@danirabbit danirabbit requested a review from a team September 6, 2020 17:23
@jeremypw
Copy link
Collaborator Author

jeremypw commented Sep 6, 2020

Yes, this was really a stop gap pending development of some local system for apps to make their shortcuts discoverable. I would note that Files already sends users to StackExchange on pressing F1. Not sure atm what other native apps do (if anything)

@jeremypw
Copy link
Collaborator Author

jeremypw commented Sep 6, 2020

I thinks pressing F1 should do something though.

@danirabbit danirabbit added the Needs Design Waiting for input from the UX team label Sep 8, 2020
@cassidyjames
Copy link
Contributor

Yeah I’m 👎 on sending folks to the web, too. If we want to show all shortcuts somewhere, it should be determined by the actions in the app itself. I’m also 👎 on Files sending people to a (third-party) website with a keypress, but I’ll file that separately. 😉

@jeremypw
Copy link
Collaborator Author

OK, withdrawing pending a better solution.

@jeremypw jeremypw closed this Sep 16, 2020
@jeremypw jeremypw deleted the F1-wiki branch September 16, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to view all keyboard shortcuts available in the app
3 participants