Keep launch animation for slower app startup #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried introducing a few seconds sleep in the startup of the Tasks app and while the spinner persists, the bounce animation does not because the appinfo launch seems to return immediately. It might just work on a real system with slow spinning disk though, if someone can test? |
zeebok
approved these changes
Feb 20, 2023
danirabbit
requested changes
Nov 7, 2023
| @@ -42,17 +42,17 @@ public class Dock.Launcher : Gtk.Button { | |||
|
|
|||
| var context = Gdk.Display.get_default ().get_app_launch_context (); | |||
| context.set_timestamp (Gdk.CURRENT_TIME); | |||
| context.launched.connect (() => { | |||
There was a problem hiding this comment.
We also need to connect to launch_failed so that we don't end up leaving the animation if the launch doesn't succeed for some reason
|
Closing this PR - will revisit the issue with a new PR later on if it's still relevant with the new Dock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171