Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App: Monitor the Desktop file to know when it has been removed #253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tintou
Copy link
Member

@tintou tintou commented Jul 9, 2024

Also:

LauncherManager: listen to the changes in launchers in the configuration file

Closes: #39

Differ the actual removal as this might be triggered by a file update.
…ion file

Allow to add a launcher and it being taken into account.
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm this doesn't actually seem to work for me. If the dock is restarted then it will remove the launcher but not while the dock is running

break;
case GLib.FileMonitorEvent.DELETED:
exists = false;
removal_timer = GLib.Timeout.add_seconds (60, () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment about why we have this on a timer?

@danirabbit danirabbit mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application icon stays after uninstalling
2 participants