Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LauncherManager: Fix crash when dnd a non desktop file #272

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

leolost2605
Copy link
Member

Fixes a crash that occured when trying to drag a non desktop file e.g. a normal textfile onto the dock.

@leolost2605 leolost2605 requested a review from a team September 18, 2024 18:05
Copy link
Contributor

@zeebok zeebok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but can reproduce and this makes sense for the fix

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the issue fixed but you can still drag & drop .desktop files from Applications Menu or Files.

@leolost2605 leolost2605 merged commit 2136dd3 into main Oct 6, 2024
4 checks passed
@leolost2605 leolost2605 deleted the leolost/dnd-fix-crash-on-non-app-file branch October 6, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants