Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instant-tooltips functionality #33

Closed
wants to merge 3 commits into from

Conversation

gforceg
Copy link

@gforceg gforceg commented Mar 15, 2020

addresses #29

instant-tooltips

@jeremypw
Copy link

Needs UX team approval for adding another setting.

@vbuell
Copy link

vbuell commented Mar 22, 2020

Shouldn't this "Instant Tooltips" switch be in Behaviour tab?

@gforceg
Copy link
Author

gforceg commented Mar 22, 2020

Yes, Behavior tab makes sense to me. I'm also not stuck on the name 'Instant Tooltips' I just wanted to make the dock behave a certain way and I had to call it something. 😄

I'll wait for the UX team to give me feedback before I make any more changes. If they are open to this chnage then options may also need to be made to the pantheon-shell switchboard plug.

@gforceg
Copy link
Author

gforceg commented Mar 23, 2020

Also, I noticed that when I reboot the feature is automatically switched off. I would like to figure out how to make this option stick. Currently I run 'plank --preferences' after rebooting.

@gforceg
Copy link
Author

gforceg commented Mar 23, 2020

@cassidyjames what do you think of this PR / issue #29 ?

@cassidyjames
Copy link

I'm not sure separate tooltip behavior makes sense here compared to whatever GTK gives us by default, but I see that plank isn't even using GTK tooltips. So I'm not sure. I don't think another setting is really the right approach, though—I think either the tooltips should be actual GTK tooltips (or as similar as possible), or they should be distinct if there's a good reason to do so. I don't think a user should have to make that decision.

@gforceg
Copy link
Author

gforceg commented Mar 23, 2020

I understand that this may just be my preference, but maybe other users feel the same? If it helps, the dash in gnome only seems to have a delay until the initial tooltip is shown After that it shows them immediately.

gnome-dash

I have not used OS/X in a long time but from my memory there is no delay on that dock whatsoever. Not that it matters, but having to stop the mouse over each icon was tedious enough (to me) to motivate me to take a look at the code and draft a PR. 🤓

@jeremypw
Copy link

@cassidyjames Is this likely to be accepted? To me the existing delay is small enough not to be a material issue.

@jeremypw jeremypw marked this pull request as draft June 22, 2021 17:13
@jeremypw
Copy link

Converting to draft as there are unresolved design issues that need deciding before the code can be reviewed. In my view, the speed of tooltip display should be optimized as a design decision and should not be a setting.

@quequotion
Copy link

Just my two cents, I'd rather have a switch for tooltips on/off, on being instant tooltips and off being no tooltips.

@danirabbit
Copy link
Member

Closing since this is based on the old plank codebase

@danirabbit danirabbit closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants