Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultitaskingView: move keyboard navigation code into WindowCloneContainer #1793

Merged
merged 7 commits into from
Feb 10, 2024

Conversation

lenemter
Copy link
Member

Fixes #6

@lenemter lenemter marked this pull request as draft October 30, 2023 13:06
@leolost2605
Copy link
Member

Any reason this is still drafting? Works pretty good in my testing and would be - if I understand it correctly - useful for #1833

@lenemter
Copy link
Member Author

lenemter commented Feb 8, 2024

@leolost2605 I was aware of #485 and thought we might remove window spread altogether, but since it has found a new purpose I'll finish this branch... someday.

@lenemter lenemter marked this pull request as ready for review February 9, 2024 12:01
@lenemter lenemter requested a review from a team February 9, 2024 12:01
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉

@leolost2605 leolost2605 merged commit 517ba7d into master Feb 10, 2024
4 checks passed
@leolost2605 leolost2605 deleted the lenemter/windowoverview-keyboard-nav branch February 10, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Can't navigate open windows with keyboard when doing Super+A
2 participants