Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow focusing a window via DesktopIntegration #1817

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Jan 2, 2024

Adds a dbus method that focuses the window with the given uid.
Is there a better way to find a window by uid instead of iterating over all windows (I'm not too familiar with gala/mutter methods)?

Goes with elementary/dock#196

@danirabbit
Copy link
Member

I haven't tested this yet but just wanna reference #1377 which was the design we were looking at based on survey results

@leolost2605
Copy link
Member Author

Would a window list with window titles in the context menu still be part of the design? I think for this and for cycling through windows by scrolling over the icon, this method here would still be useful. Also since we now have the DesktopIntegration we know quite a lot about the windows of applications so I wonder whether that was a limiting factor for the design?
Or should the window spread be the only way to cycle through windows?

@leolost2605
Copy link
Member Author

@danirabbit should we go forward on this? Or drop the window list from the context menu entirely? I personally don't use it but it's not a lot to maintain so we might as well keep it 🤷

@leolost2605 leolost2605 added Needs Design Waiting for input from the UX team and removed Conflicts labels Jan 21, 2024
@danirabbit
Copy link
Member

@leolost2605 sorry for taking so long to follow up on this. I believe the scrolling behavior is at least a somewhat popular feature so that makes sense to keep imo. I think I'd rather hold off on adding a list of windows to the menu until we get some feedback that indicates this is a useful feature for people. The feedback we've received in the past about people wanting to see a preview of the actual window in order to choose leads me to believe that the list isn't useful

@danirabbit danirabbit enabled auto-merge (squash) March 12, 2024 18:15
@danirabbit danirabbit merged commit 0a2d54f into master Mar 12, 2024
4 checks passed
@danirabbit danirabbit deleted the focus-window branch March 12, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants