-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a wayland/x11 mutter hints protocol for monitor labels #2084
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're in the stable release phase we can add new API but we can't break old API until the next major version bump
Ah right that is a thing oops 😅 |
Currently we do monitor labels quite awkard. First the display plug has to go via dbus to the daemon having to send color info, monitor index, label, x, y then the daemon spawns the labels and then gala looks at the window title and positions the label.
This can be made properly now by just using a wayland protocol/ setting the mutter hints on x11.
This will allow us to drop the GTK3 daemon with some more fine tuning to the menus so that's left to another PR.
This also includes some cleanup of the positioning logic for the shellclients by introducing a WindowPositioner which is used for both centered windows and monitor labels. That also fixes an issue that caused centered windows to sometimes not be centered.
Goes with elementary/pantheon-wayland#3 and elementary/switchboard-plug-display#401