-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the portal #284
Use the portal #284
Conversation
Hm I'm not sure about losing the actions. That was the reason I decided not to keep going with moving screenshots to quick settings was to not lose the app actions |
This comment was marked as outdated.
This comment was marked as outdated.
0e15d27
to
b7e6225
Compare
Ok the current version of this PR is now a hybrid. If it's interactive we will use the portal if not we still go directly via the gala dbus. This allows us to keep everything while reducing code duplication (the interactive dialog window). In addition to this I've opened flatpak/xdg-desktop-portal#1415 and elementary/portals#105 which should hopefully let us use the portal for everything in the future. But since this is probably OS 9 material (or will never happen if the portal maintainers disagree) I still think we should go with this for now. |
One other small interaction problem: when clicking "Cancel" on the save dialog I think we should launch the portal in interactive again since you probably want to redo your screenshot if you cancel here |
Ah sorry one more thing, I guess we can clean up unused gsettings as well from the schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great cleanup. Works totally as expected afaict
- Looses the command line options since we can't tell the portal what to do. We could keep the screen option but I don't really see a big use case for that.Fixes #283