Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the portal #284

Merged
merged 6 commits into from
Aug 12, 2024
Merged

Use the portal #284

merged 6 commits into from
Aug 12, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Aug 8, 2024

  • Pretty much same functionality
  • Automatically closes after taking screenshots which is the default use case I think
    - Looses the command line options since we can't tell the portal what to do. We could keep the screen option but I don't really see a big use case for that.
  • Launching via app actions will now still show the save dialog

Fixes #283

@leolost2605 leolost2605 requested a review from a team August 8, 2024 15:57
@danirabbit
Copy link
Member

Hm I'm not sure about losing the actions. That was the reason I decided not to keep going with moving screenshots to quick settings was to not lose the app actions

@leolost2605

This comment was marked as outdated.

@leolost2605
Copy link
Member Author

leolost2605 commented Aug 9, 2024

Ok the current version of this PR is now a hybrid. If it's interactive we will use the portal if not we still go directly via the gala dbus. This allows us to keep everything while reducing code duplication (the interactive dialog window).

In addition to this I've opened flatpak/xdg-desktop-portal#1415 and elementary/portals#105 which should hopefully let us use the portal for everything in the future. But since this is probably OS 9 material (or will never happen if the portal maintainers disagree) I still think we should go with this for now.

danirabbit

This comment was marked as resolved.

@danirabbit
Copy link
Member

One other small interaction problem: when clicking "Cancel" on the save dialog I think we should launch the portal in interactive again since you probably want to redo your screenshot if you cancel here

@danirabbit
Copy link
Member

Ah sorry one more thing, I guess we can clean up unused gsettings as well from the schema

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great cleanup. Works totally as expected afaict

@danirabbit danirabbit merged commit 87d7563 into master Aug 12, 2024
3 checks passed
@danirabbit danirabbit deleted the leolost/portal branch August 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshot window overlapping after-screenshot dialog
2 participants