Skip to content

Commit

Permalink
Changed underscore's isEmpty function to isNull because it sees {} as…
Browse files Browse the repository at this point in the history
… empty too - fixing double attribute listing on product page
  • Loading branch information
peterjaap committed Mar 20, 2018
1 parent 49ba552 commit 7f0455c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion etc/module.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Elgentos_LargeConfigProducts" setup_version="0.1.6">
<module name="Elgentos_LargeConfigProducts" setup_version="0.1.7">
</module>
</config>
4 changes: 2 additions & 2 deletions view/frontend/web/js/swatch-renderer-mixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ define([
$.widget('mage.SwatchRenderer', widget, {
// Load jsonConfig through AJAX call instead of in-line
_init: function () {
if (!_.isEmpty(this.options.jsonConfig)) {
if (!_.isNull(this.options.jsonConfig)) {
return;
}
var that = this;
Expand Down Expand Up @@ -52,4 +52,4 @@ define([

return $.mage.SwatchRenderer;
}
});
});

0 comments on commit 7f0455c

Please sign in to comment.