Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple panes #10

Open
wants to merge 18 commits into
base: dashboard_dev
Choose a base branch
from
Open

Multiple panes #10

wants to merge 18 commits into from

Conversation

mmalczak
Copy link
Collaborator

@mmalczak mmalczak commented Feb 4, 2025

Add possibility of adding multiple panes

@mmalczak mmalczak requested a review from marmeladapk February 4, 2025 22:04
@marmeladapk
Copy link
Collaborator

Fresh artiq_dashboard (when ~/.config/artiq/8/artiq_dashboard(...).pyon is deleted) starts without any pane (interesting side effect: experiments then open in new window separate from dashboard)
image

There are no scroll bars for the workspace when experiment window is placed outside of visible space:
This branch:
image
upstream:
image

Naming when closing and opening new panels is weird with (1)

New MDI Area button seems to be on its own panel that can be docked anywhere or even undocked. Instead I would do a + button on the panel next to the tabs (similar to web browsers).

Minimized experiment windows go to the bottom left of the workspace. On upstream, when the window is resized then these minimized windows are moved accordingly to be kept in view. On this branch this happens only in the active workspace, other workspaces are unnafected. Steps: minimizing experiment, switching workspace, resizing dashboard window (making it smaller) then switching back to the original workspace.

enter new name -> enter a new name

Add a hint on hovering over tab "Double click to rename"

@marmeladapk
Copy link
Collaborator

Move "+" button to the left of tabs - that way the button and tabs are connected visually.

Resizing dashboard with minimized experiment on another workspace brings the experiment to the correct place if the window is smaller than before but not when it's larger.
Steps: minimizing experiment, switching workspace, resizing dashboard window (making it bigger) then switching back to the original workspace.

@mmalczak
Copy link
Collaborator Author

Probably the behavior of the minimized windows after closing and reopening GUI could be improved.
For now, I leave it as it is, as it's the same as on the main branch.

Above mentioned issues are fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants